Bug 220758

Summary: Accelerate HTMLInputElement creation
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, rniwa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220785    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch simon.fraser: review+

Yusuke Suzuki
Reported 2021-01-19 18:21:04 PST
Accelerate HTMLInputElement creation
Attachments
Patch (56.28 KB, patch)
2021-01-19 18:27 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (56.07 KB, patch)
2021-01-19 18:29 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (56.52 KB, patch)
2021-01-19 18:43 PST, Yusuke Suzuki 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-01-19 18:27:40 PST
Created attachment 417934 [details] Patch
Yusuke Suzuki
Comment 2 2021-01-19 18:29:50 PST
Created attachment 417935 [details] Patch
Yusuke Suzuki
Comment 3 2021-01-19 18:43:06 PST
Created attachment 417937 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-01-20 11:59:07 PST
Comment on attachment 417937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417937&action=review > Source/WebCore/html/InputType.h:337 > + explicit InputType(HTMLInputElement& element, Type type) I'd prefer to see Type be the first argument to this constructor and all the derived class constructors. > Source/WebCore/html/InputType.h:350 > + Type m_type; This can be const.
Yusuke Suzuki
Comment 5 2021-01-20 12:21:24 PST
Comment on attachment 417937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417937&action=review >> Source/WebCore/html/InputType.h:337 >> + explicit InputType(HTMLInputElement& element, Type type) > > I'd prefer to see Type be the first argument to this constructor and all the derived class constructors. Sounds good. I'll change them. >> Source/WebCore/html/InputType.h:350 >> + Type m_type; > > This can be const. Nice. Fixed.
Yusuke Suzuki
Comment 6 2021-01-20 13:54:44 PST
Committed r271672: <https://trac.webkit.org/changeset/271672>
Radar WebKit Bug Importer
Comment 7 2021-01-20 13:55:15 PST
<rdar://problem/73419065>
Ryosuke Niwa
Comment 8 2021-01-20 15:50:24 PST
Nice! Blink did a similar optimization here.
Yusuke Suzuki
Comment 9 2021-01-20 18:55:02 PST
(In reply to Ryosuke Niwa from comment #8) > Nice! Blink did a similar optimization here. Oh! Nice :)
Note You need to log in before you can comment on or make changes to this bug.