| Summary: | [webkitcorepy] Support alternative default pypi url on macOS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, jlewis3, mcatanzaro, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 220736 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2021-01-19 13:00:29 PST
Created attachment 417908 [details]
Patch
Comment on attachment 417908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417908&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:320 > + parts = line.split('/') is it reliable way to depend on the line containing certain number of slashes. Can we explicitly read index/index-url from the file? maybe using a regex starting with https:// (In reply to Aakash Jain from comment #4) > maybe using a regex starting with https:// Will replace this with a regex. Created attachment 417919 [details]
Patch for landing
Committed r271630: <https://trac.webkit.org/changeset/271630> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417919 [details]. Reopening to attach new patch. Created attachment 417969 [details]
Patch for landing
Committed r271649: <https://trac.webkit.org/changeset/271649> |