Bug 220691

Summary: [JSC] Add some more exception checks in globalFuncCopyDataProperties
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2021-01-17 17:10:17 PST
[JSC] Add some more scope checks in globalFuncCopyDataProperties
Comment 1 Yusuke Suzuki 2021-01-17 17:13:47 PST
Created attachment 417786 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-17 17:14:43 PST
<rdar://problem/73242251>
Comment 3 Mark Lam 2021-01-17 21:56:50 PST
Comment on attachment 417786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review

r=me with suggested title change.

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] Add some more scope checks in globalFuncCopyDataProperties

I think "exception checks" would be more accurate than "scope checks".
Comment 4 Yusuke Suzuki 2021-01-17 22:01:17 PST
Comment on attachment 417786 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] Add some more scope checks in globalFuncCopyDataProperties
> 
> I think "exception checks" would be more accurate than "scope checks".

Thanks! Fixed.
Comment 5 Yusuke Suzuki 2021-01-17 22:03:38 PST
Committed r271568: <https://trac.webkit.org/changeset/271568>