Bug 220654

Summary: [GStreamer][Playbin3] Support for CEA-608 closed captioned media
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jenner, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220418    
Bug Blocks:    
Attachments:
Description Flags
Patch calvaris: review+

Description Philippe Normand 2021-01-15 03:54:21 PST 
.
Comment 1 Philippe Normand 2021-01-27 07:28:18 PST 
Created attachment 418546 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-01-28 01:35:17 PST 
Comment on attachment 418546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418546&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93
> +            WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs");

I would GST_ERROR on this as well, but up to you.
Comment 3 Philippe Normand 2021-01-28 09:23:12 PST 
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 418546 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418546&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93
> > +            WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs");
> 
> I would GST_ERROR on this as well, but up to you.

Well the whole pipeline would fail in this case anyway due to the unlinked pad. I'm not sure another GST_ERROR is needed :)
Comment 4 Philippe Normand 2021-01-29 02:37:03 PST 
Committed r272055: <https://trac.webkit.org/changeset/272055>
Comment 5 Radar WebKit Bug Importer 2021-01-29 02:38:26 PST 
<rdar://problem/73747252>
Comment 6 Robert Jenner 2021-02-12 11:50:16 PST 
It appears that this revision has broken then test in macOS and iOS:
media/track/track-in-band-style.html

Bug created:
https://bugs.webkit.org/show_bug.cgi?id=221835
Comment 7 Robert Jenner 2021-02-12 11:59:36 PST 
Jer has informed us, that this is a rebaseline. We are going to rebaseline with:

https://bugs.webkit.org/show_bug.cgi?id=221835