Bug 220606

Summary: Add a quirk to disable "return to element fullscreen from picture-in-picture" for some sites
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225322
Attachments:
Description Flags
Patch
none
Rebase the patch
none
Fix build failures
none
Patch
none
Revise the patch based on Eric's comment none

Description Peng Liu 2021-01-13 15:21:36 PST 
Add a quirk to disable "return to element fullscreen from picture-in-picture" for some sites
Comment 1 Peng Liu 2021-01-13 15:32:41 PST 
Created attachment 417572 [details]
Patch
Comment 2 Peng Liu 2021-01-13 15:33:27 PST 
<rdar://problem/70788878>
Comment 3 Peng Liu 2021-01-13 16:00:23 PST 
Created attachment 417575 [details]
Rebase the patch
Comment 4 Peng Liu 2021-01-13 19:15:50 PST 
Created attachment 417591 [details]
Fix build failures
Comment 5 Peng Liu 2021-01-13 20:57:17 PST 
Created attachment 417595 [details]
Patch
Comment 6 Eric Carlson 2021-01-14 10:47:55 PST 
Comment on attachment 417595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417595&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:893
> +    if (!_blocksReturnToFullscreenFromPictureInPicture)
> +        _shouldReturnToFullscreenFromPictureInPicture = YES;

This could be simplified to `_shouldReturnToFullscreenFromPictureInPicture = !_blocksReturnToFullscreenFromPictureInPicture`
Comment 7 Peng Liu 2021-01-14 11:26:46 PST 
Comment on attachment 417595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417595&action=review

>> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:893
>> +        _shouldReturnToFullscreenFromPictureInPicture = YES;
> 
> This could be simplified to `_shouldReturnToFullscreenFromPictureInPicture = !_blocksReturnToFullscreenFromPictureInPicture`

Right!
Comment 8 Peng Liu 2021-01-14 14:17:54 PST 
Created attachment 417652 [details]
Revise the patch based on Eric's comment
Comment 9 EWS 2021-01-14 15:17:25 PST 
Committed r271503: <https://trac.webkit.org/changeset/271503>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417652 [details].