Bug 220573

Summary: PCM: Experimental debug mode needs to be read from defaults differently on iOS
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

John Wilander
Reported 2021-01-12 16:54:01 PST
Experimental features on iOS use the prefix "WebKitExperimental." We should read it that way.
Attachments
Patch (2.17 KB, patch)
2021-01-12 16:59 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.21 KB, patch)
2021-01-13 11:11 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-12 16:55:05 PST
<rdar://problem/73092137>
John Wilander
Comment 2 2021-01-12 16:59:31 PST
Created attachment 417499 [details] Patch
Brent Fulgham
Comment 3 2021-01-13 09:43:19 PST
Comment on attachment 417499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417499&action=review r=me > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:497 > +#if PLATFORM(IOS) I would suggest #elif PLATFORM(IOS). > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:498 > + parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:@"WebKitExperimental%@", WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]]; Sometimes we do #else with a "notImplemented()" but it's probably not warranted in this case.
John Wilander
Comment 4 2021-01-13 11:11:50 PST
Created attachment 417549 [details] Patch for landing
John Wilander
Comment 5 2021-01-13 11:14:07 PST
Thanks, Brent!
EWS
Comment 6 2021-01-13 11:42:35 PST
Committed r271448: <https://trac.webkit.org/changeset/271448> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417549 [details].
Note You need to log in before you can comment on or make changes to this bug.