| Summary: | REGRESSION (r265044): [macOS] Safari autocorrects text when typing in login field on amazon.com | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, megan_gardner, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2021-01-12 12:13:55 PST
Created attachment 417478 [details]
Patch
Comment on attachment 417478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417478&action=review > Source/WebKit/ChangeLog:11 > + Restores the implementation of `WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled`, which was removed in > + r265044, with the reasoning that the code was unused. However, Safari still uses this SPI on macOS to prevent > + automatic spelling correction from triggering when editing form fields that are AutoFillable. Wow, how did I miss that? Was that the only mistake of the 12 functions that I claimed were unused? Thanks for the review! Yes, this seems to be the only one that is unused. While there are several SPI functions that have call sites in Safari code (more specifically, their C++ wrapper objects), the methods on those wrappers are unused in Safari code as well. (In reply to Darin Adler from comment #2) > Comment on attachment 417478 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417478&action=review > > > Source/WebKit/ChangeLog:11 > > + Restores the implementation of `WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled`, which was removed in > > + r265044, with the reasoning that the code was unused. However, Safari still uses this SPI on macOS to prevent > > + automatic spelling correction from triggering when editing form fields that are AutoFillable. > > Wow, how did I miss that? > > Was that the only mistake of the 12 functions that I claimed were unused? > Yes, this seems to be the only one that is unused.
(I meant to write "only one that is _not_ unused")
Committed r271414: <https://trac.webkit.org/changeset/271414> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417478 [details]. |