Bug 220552

Summary: [ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: amir_mark, jean-yves.avenard, jer.noble, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Add commit log into ChangeLog (I had it in the git commit before and it got lost when uploaded)
none
Patch for landing none

Description Truitt Savell 2021-01-12 10:52:44 PST
media/media-source/media-source-webm-init-inside-segment.html

This test is failing constantly on Big Sur

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-source%2Fmedia-source-webm-init-inside-segment.html

Diff:
--- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-actual.txt
@@ -5,15 +5,6 @@
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-Append a new Initialization Segment.
-RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
-EVENT(update)
+EVENT(error) TEST(false) FAIL
 END OF TEST
Comment 1 Radar WebKit Bug Importer 2021-01-12 10:54:37 PST
<rdar://problem/73048070>
Comment 2 Truitt Savell 2021-01-12 10:56:48 PST
This test began showing in history after the changes in r271039
Comment 3 Truitt Savell 2021-01-12 13:16:18 PST
marked as failing in https://trac.webkit.org/changeset/271412/webkit
Comment 4 Jean-Yves Avenard [:jya] 2021-01-27 15:40:20 PST
Created attachment 418590 [details]
Patch
Comment 5 Jean-Yves Avenard [:jya] 2021-01-27 15:52:19 PST
Created attachment 418594 [details]
Patch
Comment 6 Jean-Yves Avenard [:jya] 2021-01-27 21:53:22 PST
Created attachment 418617 [details]
Add commit log into ChangeLog (I had it in the git commit before and it got lost when uploaded)
Comment 7 EWS 2021-01-28 17:56:45 PST
Tools/Scripts/svn-apply failed to apply attachment 418617 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Jean-Yves Avenard [:jya] 2021-01-28 18:09:40 PST
Created attachment 418687 [details]
Patch for landing
Comment 9 EWS 2021-01-28 18:54:42 PST
Committed r272043: <https://trac.webkit.org/changeset/272043>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418687 [details].
Comment 10 Amir Mark Jr 2021-02-04 14:31:22 PST
*** Bug 221426 has been marked as a duplicate of this bug. ***
Comment 12 Truitt Savell 2021-02-04 14:36:05 PST
Diff has changed:

--- /Volumes/Data/slave/bigsur-release-tests-wk1/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk1/build/layout-test-results/media/media-source/media-source-webm-init-inside-segment-actual.txt
@@ -4,16 +4,9 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-Append a new Initialization Segment.
-RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1)))
-EVENT(update)
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST
Comment 13 Ryan Haddad 2021-02-11 16:24:02 PST
(In reply to Truitt Savell from comment #11)
> This change https://trac.webkit.org/changeset/272043/webkit
> 
> did not fix the test. it is still failing.
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-
> source%2Fmedia-source-webm-init-inside-segment.html
It looks like the change fixed the test for WK2, but it continues to fail on WK1.

Should we just be disabling all these webm tests on WK1 as won't fix, or are they expected to work?
Comment 14 Ryan Haddad 2021-02-12 15:35:51 PST
(In reply to Ryan Haddad from comment #13)
> (In reply to Truitt Savell from comment #11)
> > This change https://trac.webkit.org/changeset/272043/webkit
> > 
> > did not fix the test. it is still failing.
> > 
> > History:
> > https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-
> > source%2Fmedia-source-webm-init-inside-segment.html
> It looks like the change fixed the test for WK2, but it continues to fail on
> WK1.
> 
> Should we just be disabling all these webm tests on WK1
Skipped in r272818