Bug 220544

Summary: [build.webkit.org] Update force schedulers as per new buildbot
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2021-01-12 08:44:07 PST
[build.webkit.org] Update force schedulers as per new buildbot. Force schedulers class parameters have changed in newer Buildbot versions. We should change the code accordingly to support the new parameters.
Attachments
Patch (3.02 KB, patch)
2021-01-12 08:46 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-01-12 08:46:47 PST
ForceScheduler class in newer buildbot doesn't accept parameters like: branch, repository, project.
Aakash Jain
Comment 2 2021-01-12 08:46:53 PST
Created attachment 417458 [details] Patch
Aakash Jain
Comment 3 2021-01-12 08:47:42 PST
Tested on dev instance.
Jonathan Bedard
Comment 4 2021-01-12 08:57:44 PST
Comment on attachment 417458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417458&action=review > Tools/CISupport/build-webkit-org/loadConfig.py:91 > + revision=StringParameter(name="revision", default="", regex=re.compile(r'^(\d*)$')), What are the implications for this argument in a Git world?
Aakash Jain
Comment 5 2021-01-12 09:01:45 PST
(In reply to Jonathan Bedard from comment #4) > What are the implications for this argument in a Git world? Good thing is that we won't be using it in new buildbot anymore. In old buildbot, it is restricting that specified revision should be in svn revision format while doing a force build.
EWS
Comment 6 2021-01-12 09:30:59 PST
Committed r271406: <https://trac.webkit.org/changeset/271406> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417458 [details].
Radar WebKit Bug Importer
Comment 7 2021-01-12 09:31:14 PST
<rdar://problem/73044118>
Note You need to log in before you can comment on or make changes to this bug.