Bug 220527

Summary:	fast/hidpi and svg/filters/hidpi don't run in hidpi mode
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	REOPENED ---
Severity:	Normal	CC:	ap, ryanhaddad, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Simon Fraser (smfr) 2021-01-11 15:40:56 PST

Testing code does:

static std::optional<double> overrideDeviceScaleFactorForTest(const std::string& pathOrURL)
{
    if (pathContains(pathOrURL, "/hidpi-3x-"))
        return 3;
    if (pathContains(pathOrURL, "/hidpi-"))
        return 2;
    return std::nullopt;
}

but those directories don't match.

Comment 1 Alexey Proskuryakov 2021-01-11 16:42:34 PST

As far as I can tell, this has always been the case. At least some of those tests use testRunner.setBackingScaleFactor.

Note that even though the quoted code is from TestRunnerShared, DumpRenderTree has a copy of this logic.

Comment 2 Radar WebKit Bug Importer 2021-01-18 15:41:13 PST

<rdar://problem/73331633>

Comment 3 Alexey Proskuryakov 2021-01-20 14:16:34 PST

I'll say "behaves correctly", please feel free to reopen if you disagree.

Comment 4 Simon Fraser (smfr) 2021-01-20 14:35:08 PST

There are tests in those directories that are obviously written with the assumption that they are running in hidpi, so something needs to change.