| Summary: | TypedArray's [[DefineOwnProperty]] should throw in case of failure | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||||
| Component: | JavaScriptCore | Assignee: | Alexey Shvayka <ashvayka> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Trivial | CC: | darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Shvayka
2021-01-08 18:10:21 PST
Created attachment 417324 [details]
Patch
Comment on attachment 417324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417324&action=review > Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:409 > + typename Adaptor::Type value = toNativeFromValue<Adaptor>(globalObject, descriptor.value()); Do we really need Adaptor::Type here. Would auto work? Created attachment 421957 [details]
Patch
Adjust tests and don't throw if the buffer was detached during the coercion.
(In reply to Darin Adler from comment #2) Thank you for review! > Do we really need Adaptor::Type here. Would auto work? I've reverted this bit as it was spec-incorrect: in a very unlike case of [[Value]] coercion detaching the buffer, we should silently ignore it. Created attachment 421963 [details]
Patch
Fix unchecked exception.
Committed r273750: <https://commits.webkit.org/r273750> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421963 [details]. |