| Summary: | [Mac] Netflix controls do not fade out after entering fullscreen | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, peng.liu6, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2021-01-08 12:04:05 PST
Created attachment 417289 [details]
Patch
Created attachment 417583 [details]
Patch
Comment on attachment 417583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417583&action=review > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:401 > + // FIXME(53342): remove once pointer events fire when elements move out from under the pointer. 2011! > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:408 > + eventNumber:0 clickCount:0 pressure:0]; Nit: is there any reason to not put these an separate lines like the others? (In reply to Eric Carlson from comment #4) > Comment on attachment 417583 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417583&action=review > > > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:401 > > + // FIXME(53342): remove once pointer events fire when elements move out from under the pointer. > > 2011! Yeah. :-/ > > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:408 > > + eventNumber:0 clickCount:0 pressure:0]; > > Nit: is there any reason to not put these an separate lines like the others? Not really; it's a bit of copy-pasta. Created attachment 417980 [details]
Patch for landing
Committed r271656: <https://trac.webkit.org/changeset/271656> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417980 [details]. |