Bug 220451

Summary: [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2021-01-07 18:23:31 PST
[JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge
Comment 1 Yusuke Suzuki 2021-01-07 18:33:43 PST
Created attachment 417235 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-07 18:34:01 PST
<rdar://problem/71237065>
Comment 3 Mark Lam 2021-01-07 19:07:25 PST
Comment on attachment 417235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review

r=me with ChangeLog fix.

> Source/JavaScriptCore/ChangeLog:11
> +        and if it is, we should make it generic one instead of using fast TypedArray path.

I think you meant to say "if it is not" instead here.
Comment 4 Yusuke Suzuki 2021-01-07 19:08:02 PST
Comment on attachment 417235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review

>> Source/JavaScriptCore/ChangeLog:11
>> +        and if it is, we should make it generic one instead of using fast TypedArray path.
> 
> I think you meant to say "if it is not" instead here.

Thanks! Fixed.
Comment 5 Yusuke Suzuki 2021-01-08 08:30:43 PST
Committed r271297: <https://trac.webkit.org/changeset/271297>