Bug 220435

Summary: PlaybackSessionManager::m_clientCounts is not updated correctly when a video enters picture-in-picture from fullscreen
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220467
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing
none
Patch none

Description Peng Liu 2021-01-07 14:16:46 PST 
PlaybackSessionManager::m_clientCounts is not updated correctly when a video enters picture-in-picture from fullscreen
Comment 1 Peng Liu 2021-01-07 14:22:31 PST 
<rdar://problem/70749570>
Comment 2 Peng Liu 2021-01-07 14:25:41 PST 
Created attachment 417212 [details]
Patch
Comment 3 Eric Carlson 2021-01-07 14:33:58 PST 
Comment on attachment 417212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417212&action=review

> Source/WebKit/ChangeLog:11
> +        because `m_clientCounts` has been updated when the video enters fullscreen.

s/has been updated when the video enters/was updated when the video entered/
Comment 4 Peng Liu 2021-01-07 14:37:48 PST 
Created attachment 417213 [details]
Patch for landing
Comment 5 EWS 2021-01-07 16:31:03 PST 
Committed r271273: <https://trac.webkit.org/changeset/271273>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417213 [details].
Comment 6 Peng Liu 2021-01-08 12:05:43 PST 
Reopening to attach new patch.
Comment 7 Peng Liu 2021-01-08 12:05:44 PST 
Created attachment 417288 [details]
Patch
Comment 8 EWS 2021-01-08 14:45:41 PST 
Committed r271325: <https://trac.webkit.org/changeset/271325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417288 [details].