| Summary: | PaintFrameForMedia has a null identifier when media player is a media stream track video player | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer, wenson_hsieh, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2021-01-07 06:35:40 PST
Created attachment 417176 [details]
Patch
Comment on attachment 417176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review > Source/WebCore/platform/graphics/GraphicsContextImpl.h:108 > + virtual bool canPaintFrameForMedia(const MediaPlayer&) const = 0; I think you'll need to update this method for other platforms as well (i.e. Windows, Cairo, Nicosia). Comment on attachment 417176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review > Source/WebCore/ChangeLog:12 > + Covered by test in gu process mode. Nit - "gu" => "GPU" Created attachment 417259 [details]
Reuploading to run on bots
Committed r271295: <https://trac.webkit.org/changeset/271295> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417259 [details]. |