Bug 220376

Summary:

[macOS] Text inside form controls is off center on burton.com

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, koivisto, macpherson, menard, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

macOS 11

Attachments:

Description	Flags
Screenshot	none
Patch	hi: review+, ews-feeder: commit-queue-
Patch for landing	none

Description Aditya Keerthi 2021-01-06 11:51:40 PST

Created attachment 417109 [details]
Screenshot

Observed when interacting with <select> elements in Burton's checkout flow.

Comment 1 Aditya Keerthi 2021-01-06 11:54:07 PST

Created attachment 417110 [details]
Patch

Comment 2 Aditya Keerthi 2021-01-06 11:56:17 PST

<rdar://problem/72833977>

Comment 3 Devin Rousso 2021-01-06 11:59:22 PST

Comment on attachment 417110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417110&action=review

r=me

> Source/WebCore/css/html.css:1017
> +select:matches([size=""], [size="0"], [size="1"]) {

NIT: should we change this to `:is` while we're at it?

Comment 4 Aditya Keerthi 2021-01-06 12:42:14 PST

Created attachment 417115 [details]
Patch for landing

Comment 5 EWS 2021-01-06 15:45:57 PST

Committed r271218: <https://trac.webkit.org/changeset/271218>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417115 [details].