Bug 220370

Summary: watchOS make clean/installsrc fail with xcodebuild: error: You cannot specify -alltargets and also specify individual targets.
Product: WebKit Reporter: Ryan Hostetler <rhost>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, emw, eric.carlson, ews-watchlist, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Ryan Hostetler 2021-01-06 10:38:55 PST 
rdar://72834872

Running make clean or make installsrc with watchOS SDK fails with error:

xcodebuild: error: You cannot specify -alltargets and also specify individual targets.
make[3]: *** [installsrc] Error 64
make[2]: *** [installsrc] Error 2
make[1]: *** [installsrc] Error 2
make: *** [installsrc] Error 2

Reproduce locally with:
make installsrc SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS7.0.sdk SRCROOT=/tmp/Source.Clean
make clean SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/WatchOS.platform/Developer/SDKs/WatchOS7.0.sdk SRCROOT=/tmp/Source.Clean
Comment 1 Ryan Hostetler 2021-01-06 10:55:17 PST 
Created attachment 417102 [details]
Patch
Comment 2 Ryan Hostetler 2021-01-06 11:39:45 PST 
Created attachment 417108 [details]
Patch
Comment 3 Ryan Hostetler 2021-01-06 12:06:08 PST 
Created attachment 417111 [details]
Patch
Comment 4 Andy Estes 2021-01-06 12:11:46 PST 
Comment on attachment 417111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417111&action=review

> Source/ThirdParty/libwebrtc/Makefile:5
> +		TARGET = -target boringssl

Nit: I'd call this XCODE_TARGET, since our Makefiles are cross-platform and this refers to Xcode's concept of a target.
Comment 5 Ryan Hostetler 2021-01-06 12:18:15 PST 
Created attachment 417112 [details]
Patch
Comment 6 EWS 2021-01-07 14:30:30 PST 
Committed r271260: <https://trac.webkit.org/changeset/271260>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417112 [details].