| Summary: | Stop using MediaRecorder in API test WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||
| Component: | Tools / Tests | Assignee: | Sihui Liu <sihui_liu> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ryanhaddad, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sihui Liu
2021-01-05 16:59:23 PST
Created attachment 417057 [details]
Patch
Comment on attachment 417057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417057&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:130 > + for (_WKExperimentalFeature *feature in [WKPreferences _experimentalFeatures]) { It might be best to not use media recorder or to make the test work in both cases (MediaRecorder on or off). WTR can use MediaRecorder with a mock backend in all platforms but the real backend is only supported for recent MacOS versions. Created attachment 417100 [details]
Patch
(In reply to youenn fablet from comment #2) > Comment on attachment 417057 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417057&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:130 > > + for (_WKExperimentalFeature *feature in [WKPreferences _experimentalFeatures]) { > > It might be best to not use media recorder or to make the test work in both > cases (MediaRecorder on or off). > WTR can use MediaRecorder with a mock backend in all platforms but the real > backend is only supported for recent MacOS versions. Removed media recorder and use audio element instead. *** Bug 220425 has been marked as a duplicate of this bug. *** Comment on attachment 417100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417100&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:34 > +#import <WebKit/_WKExperimentalFeature.h> No longer needed. > Tools/TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-basic.html:32 > + }; I would simplify this and just do: audio.play(); It might be best also to add the audio element to the DOM. Maybe just add something like: <audio id="audio" autoplay></audio> And then write audio.play() here. Created attachment 417273 [details]
Patch for landing
Created attachment 417274 [details]
Patch for landing
Found 1 new test failure: media/controls/showControlsButton.html Committed r271311: <https://trac.webkit.org/changeset/271311> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417274 [details]. |