| Summary: | PCM: Experimental debug mode stops working after initial use | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> | ||||
| Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
John Wilander
2021-01-05 13:49:28 PST
Created attachment 417035 [details]
Patch
Comment on attachment 417035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417035&action=review r=me > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327 > +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled) Is this always called on NetworkProcess initialization? And I assume toggling the setting switch in UIProcess sends a message that hits this? Comment on attachment 417035 [details]
Patch
Thanks, Brent!
(In reply to Brent Fulgham from comment #3) > Comment on attachment 417035 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417035&action=review > > r=me > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327 > > +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled) > > Is this always called on NetworkProcess initialization? And I assume > toggling the setting switch in UIProcess sends a message that hits this? I don't know actually. I think this may be a feature switch that requires a browser restart. Committed r271184: <https://trac.webkit.org/changeset/271184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417035 [details]. |