Bug 220335

Summary: [WPE][GTK] File descriptor leak
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED MOVED    
Severity: Normal CC: bugs-noreply, mcatanzaro, tpopela
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220090

Description Michael Catanzaro 2021-01-05 13:14:57 PST 
Open MiniBrowser (or Epiphany), launch five browser tabs, and use gnome-system-monitor to inspect the open files of the first and last WebKitWebProcess. Do not use flatpak, because when running Epiphany under flatpak, everything seems fine for some reason I don't understand. But when running outside flatpak, I see the number of local sockets usually -- but not always -- increases by 2 for each web process launched. We are leaking some file descriptors... somewhere.

Sadly, this is going to be hard to debug.
Comment 1 Michael Catanzaro 2021-01-18 09:07:28 PST 
From bug #220090, we can probably avoid this by removing G_SUBPROCESS_FLAGS_INHERIT_FDS, but to do that we need a way to exempt the WPE render host socket by passing it to ProcessLauncher and from there to g_subprocess_launcher_take_fd(). r241816 -- which seemed like a nice cleanup at the time -- made this harder.
Comment 2 Michael Catanzaro 2021-02-23 13:13:55 PST 
I tracked this down to wpebackend-fdo, https://github.com/Igalia/WPEBackend-fdo/pull/136.