Bug 220259

Summary: [LFC][IFC] Do not use LineBox::isConsideredEmpty when checking if inline box stretches the line box
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2021-01-04 19:28:12 PST 
e.g. <!DOCTYPE html><span><div></div></span> the pre and post blocks 

block container (pre)
 inline box
block container
block container (post)
  inline box
-no struts in these generated content.
Comment 1 zalan 2021-01-04 19:34:37 PST 
Created attachment 416970 [details]
Patch
Comment 2 zalan 2021-01-10 20:16:26 PST 
Created attachment 417360 [details]
Patch
Comment 3 Antti Koivisto 2021-01-10 22:28:07 PST 
Comment on attachment 417360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417360&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:-60
> -        bool isLineConsideredEmpty { true };

Nice
Comment 4 Radar WebKit Bug Importer 2021-01-11 19:29:13 PST 
<rdar://problem/73023402>
Comment 5 zalan 2021-01-13 09:53:59 PST 
Created attachment 417542 [details]
Patch
Comment 6 zalan 2021-01-14 06:58:17 PST 
Created attachment 417617 [details]
Patch
Comment 7 zalan 2021-01-15 20:37:39 PST 
Created attachment 417757 [details]
Patch
Comment 8 zalan 2021-01-15 20:43:29 PST 
Created attachment 417758 [details]
Patch
Comment 9 zalan 2021-01-15 21:40:27 PST 
Created attachment 417761 [details]
Patch
Comment 10 EWS 2021-01-16 06:28:43 PST 
Committed r271555: <https://trac.webkit.org/changeset/271555>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417761 [details].