Bug 220249

Summary: [LFC][Integration] Factor marked text style collection code out of InlineTextBox
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, megan_gardner, mmaxfield, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch
ews-feeder: commit-queue-
patch
zalan: review+, ews-feeder: commit-queue-
patch none

Antti Koivisto
Reported 2021-01-04 10:43:50 PST
So we can teach LFC to paint selections and other marked text.
Attachments
patch (23.27 KB, patch)
2021-01-04 10:46 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (28.21 KB, patch)
2021-01-04 11:41 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (33.57 KB, patch)
2021-01-05 07:18 PST, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (31.92 KB, patch)
2021-01-10 05:42 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-01-04 10:46:06 PST
Created attachment 416956 [details] patch
Antti Koivisto
Comment 2 2021-01-04 11:41:22 PST
Created attachment 416957 [details] patch
Antti Koivisto
Comment 3 2021-01-05 07:18:14 PST
Created attachment 417002 [details] patch
alan
Comment 4 2021-01-05 11:05:46 PST
Comment on attachment 417002 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=417002&action=review > Source/WebCore/rendering/MarkedTextStyle.h:57 > + float alpha; hope this never leads to random alpha.
EWS
Comment 5 2021-01-10 03:56:35 PST
Tools/Scripts/svn-apply failed to apply attachment 417002 [details] to trunk. Please resolve the conflicts and upload a new patch.
Antti Koivisto
Comment 6 2021-01-10 05:42:55 PST
Created attachment 417348 [details] patch
EWS
Comment 7 2021-01-10 10:09:14 PST
Committed r271350: <https://trac.webkit.org/changeset/271350> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417348 [details].
Radar WebKit Bug Importer
Comment 8 2021-01-10 10:10:20 PST
<rdar://problem/72976067>
Antti Koivisto
Comment 9 2021-01-11 09:39:22 PST
Build fix https://trac.webkit.org/changeset/271364/webkit
Note You need to log in before you can comment on or make changes to this bug.