| Summary: | [WASM-References] Fix data section parsing and add more tests from ref-types | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dmitry <dbezhetskov> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Dmitry
2021-01-04 02:48:18 PST
Created attachment 416931 [details]
Patch
Comment on attachment 416931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416931&action=review r=me with comment. > Source/JavaScriptCore/wasm/WasmSectionParser.cpp:747 > + const char* errorMessage = Options::useWebAssemblyReferences() ? "th Data segment's flag" : "th Data segment's index"; I think we should just throw an error with `"th Data segment's flag"`. Created attachment 416971 [details]
Patch
Committed r271141: <https://trac.webkit.org/changeset/271141> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416971 [details]. |