Bug 220234

Summary: Fix count failure check in LayoutTests/webrtc/h264-high.html
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, peng.liu6, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2021-01-04 01:38:19 PST
Fix count failure check in LayoutTests/webrtc/h264-high.html
Comment 1 youenn fablet 2021-01-04 01:44:24 PST
Created attachment 416927 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-01-04 07:14:05 PST
<rdar://problem/72791771>
Comment 3 youenn fablet 2021-01-04 07:14:29 PST
On iOS simulator, I get some errors like:
47373	default	16:07:53.225518+0100	com.apple.WebKit.WebContent.Development	<<<< VT-CS >>>> vtCompressionSessionCompressionWork: vtCompressionSessionEncodeWork -10377
Comment 4 youenn fablet 2021-01-05 05:26:31 PST
Created attachment 416997 [details]
Patch
Comment 5 Peng Liu 2021-01-05 10:11:25 PST
Comment on attachment 416997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416997&action=review

> LayoutTests/ChangeLog:12
> +        Add ios specific expectations since high resolutions do not seem supported there.

s/do not/are not/
Comment 6 Eric Carlson 2021-01-06 09:43:24 PST
Comment on attachment 416997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416997&action=review

>> LayoutTests/ChangeLog:12
>> +        Add ios specific expectations since high resolutions do not seem supported there.
> 
> s/do not/are not/

"do not seem to be supported" would be cleaner.
Comment 7 youenn fablet 2021-01-07 00:10:58 PST
Created attachment 417161 [details]
Patch for landing
Comment 8 EWS 2021-01-08 09:03:06 PST
Committed r271301: <https://trac.webkit.org/changeset/271301>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417161 [details].