Bug 220213

Summary: [LFC Display] Give display boxes a previousSibling pointer
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch zalan: review+

Simon Fraser (smfr)
Reported 2020-12-31 12:32:19 PST
[LFC Display] Give display boxes a previousSibling pointer
Attachments
Patch (3.49 KB, patch)
2020-12-31 12:33 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2021-08-14 18:10 PDT, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-12-31 12:33:00 PST
Created attachment 416869 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-01-02 17:37:17 PST
Note to self: need to add a lastChild pointer to ContainerBox.
Radar WebKit Bug Importer
Comment 3 2021-01-07 12:33:12 PST
<rdar://problem/72900722>
Simon Fraser (smfr)
Comment 4 2021-08-14 18:10:12 PDT
Created attachment 435554 [details] Patch
alan
Comment 5 2021-08-15 07:25:27 PDT
Comment on attachment 435554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435554&action=review > Source/WebCore/ChangeLog:10 > + Hit-testing will need to iterate Display::Box siblings in reverse order, so add > + a pointer to the previous sibling box, and assign it during tree building. Also > + add a lastChild pointer to Display::ContainerBox. In integration we just iterate the vector backwards. nvm, it looks like DisplayBox objects are already forming a tree. > Source/WebCore/display/css/DisplayBox.h:101 > + Box* m_previousSibling { nullptr }; WeakPtr? > Source/WebCore/display/css/DisplayContainerBox.h:51 > + Box* m_lastChild { nullptr }; WeakPtr?
Note You need to log in before you can comment on or make changes to this bug.