| Summary: | Update root level scripts in Tools/Scripts to Python 3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, darin, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2020-12-30 12:08:19 PST
Created attachment 416849 [details]
proposed patch
Comment on attachment 416849 [details]
proposed patch
I’m assuming these changes are all compatible with both Python 2 and Python 3 even though the comment doesn’t say that specifically.
Comment on attachment 416849 [details]
proposed patch
Correct, I verified compatibility with both to the best of my ability.
Comment on attachment 416849 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=416849&action=review > Tools/Scripts/dump-webkit-tests-run:5 > +import six Need to import webkitpy first to get the auto-installed six > Tools/Scripts/dump-webkit-tests-run:19 > + six.print_("file not found: %s" % args[0], file=sys.stderr) Could also use sys.stderr.write(...) > Tools/Scripts/rebase-patch-after-webkit-move:52 > + for current_name, rebased_name in six.iteritems(REBASE_DICTIONARY): Could just use ".items()" to avoid the six dependency (If we don't care about that, should probably import webkitpy so we get the auto-installed six) > Tools/Scripts/sync-feature-defines:30 > +import six Need to import webkitpy first so we get the auto-installed six. > Could just use ".items()" to avoid the six dependency (If we don't care
> about that, should probably import webkitpy so we get the auto-installed six)
While I didn't actually measure performance, it seems reasonable to keep using an iterator to avoid regressing it.
Thank you for catching the auto-install issue!
Committed https://trac.webkit.org/r271151 Comment on attachment 416849 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=416849&action=review > Tools/Scripts/extract-dependencies-from-makefile:-37 > -from __future__ import print_function This was necessary, removing it broke the build. Re-added in r271159. Will double-check the other print_function removals now. Comment on attachment 416849 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=416849&action=review > Tools/Scripts/make-dist:-18 > -from __future__ import print_function This was also needed, reverted in r271161. The rest of print_function removals were fine AFAICT. |