| Summary: | Share meta refresh logic | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, darin, esprehn+autocc, ews-watchlist, japhet, kangil.han, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2020-12-27 08:13:02 PST
Created attachment 416822 [details]
Patch
Comment on attachment 416822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review > Source/WebCore/ChangeLog:8 > + Share meta refresh logic between Document and FrameLoader. This change is great; two copies seems silly! Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that. Created attachment 416909 [details]
Patch
Committed r271125: <https://trac.webkit.org/changeset/271125> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416909 [details]. Comment on attachment 416822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review >> Source/WebCore/ChangeLog:8 >> + Share meta refresh logic between Document and FrameLoader. > > This change is great; two copies seems silly! > > Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that. Thanks for that reminder! Based on that, I moved the new method to FrameLoader instead of Document. |