Bug 220135

Summary:

[LFC][Integration] Use the pre-computed geometries for the inline level boxes

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description zalan 2020-12-23 20:40:12 PST

instead of looping through the inline content and computed them all over again.

Comment 1 Radar WebKit Bug Importer 2020-12-23 20:40:32 PST

<rdar://problem/72642850>

Comment 2 zalan 2020-12-23 20:44:16 PST

Created attachment 416736 [details]
Patch

Comment 3 zalan 2020-12-23 21:13:45 PST

Created attachment 416737 [details]
Patch

Comment 4 Antti Koivisto 2020-12-25 08:38:07 PST

Comment on attachment 416737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416737&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70
> +    // For integration only.
> +    void collectInlineContentIfNeeded();
> +    void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&);

Saying that these are "intergration only" is bit misleading since they are used internally in any case. They are just public for integration.

Maybe these could stay private and there could be public 'lineLayoutForIntergration' or similar that calls them?

Comment 5 zalan 2020-12-25 11:30:57 PST

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 416737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416737&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70
> > +    // For integration only.
> > +    void collectInlineContentIfNeeded();
> > +    void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const ConstraintsForInFlowContent&);
> 
> Saying that these are "intergration only" is bit misleading since they are
> used internally in any case. They are just public for integration.
> 
> Maybe these could stay private and there could be public
> 'lineLayoutForIntergration' or similar that calls them?
Yeah, I like that.

Comment 6 zalan 2020-12-25 12:15:43 PST

Created attachment 416757 [details]
Patch

Comment 7 EWS 2020-12-25 13:46:40 PST

Committed r271085: <https://trac.webkit.org/changeset/271085>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416757 [details].