Bug 220129

Summary: [ANGLE] Metal backend renders tdl.js samples as red
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jdarpinian, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404, 219759, 220076    
Attachments:
Description Flags
Patch none

Kyle Piddington
Reported 2020-12-23 15:23:18 PST
As reported by Ken Russell, TDL samples render a red background. The root cause of this issue is an incorrect color mask for a texture blit. Instead of all channels being blitted, ANGLE tries to blit only the colors present specified by glColorMask Blitting shouldn't be affected by the color mask.
Attachments
Patch (1.72 KB, patch)
2020-12-23 15:24 PST, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2020-12-23 15:24:42 PST
Created attachment 416727 [details] Patch
EWS Watchlist
Comment 2 2020-12-23 15:25:32 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2020-12-23 15:51:46 PST
Comment on attachment 416727 [details] Patch Fantastic find and fix Kyle! Verified locally that this fixes the WebGL Aquarium with the Metal backend. r+
Kenneth Russell
Comment 4 2020-12-23 16:46:14 PST
Comment on attachment 416727 [details] Patch Passed EWS; let me CQ this before the tree closure.
EWS
Comment 5 2020-12-23 17:00:57 PST
Committed r271080: <https://trac.webkit.org/changeset/271080> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416727 [details].
Radar WebKit Bug Importer
Comment 6 2020-12-23 17:03:22 PST
<rdar://problem/72638743>
Note You need to log in before you can comment on or make changes to this bug.