| Summary: | Remove non-inclusive language from imported tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | achristensen, bdakin, cdumez, ggaren, gsnedders, simon.fraser, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 256752 | ||
| Bug Blocks: | 213092 | ||
|
Description
Beth Dakin
2020-12-22 10:46:34 PST
What's in w3c/web-platform-tests/tools/third_party/ is slightly complicated because WPT has generally avoided forking the libraries we vendor in, even though we're largely on outdated versions (due to the necessity to support Python 2 for WebKit). All the expectation files in html/webappapis/system-state-and-capabilities/the-navigator-object/ seem to be orphaned, with no test associated with them, so those should just be deletable? Guess our current import script doesn't manage to delete them? Most of the rest seem to have been fixed upstream, at least. As for your question about lint.ignore: we can probably just apply https://github.com/web-platform-tests/wpt/commit/622c9625dddfdef0c6dfafa8fa00d5119db50201 locally? Thanks for your reply, Sam! Some comments inline. (In reply to Sam Sneddon [:gsnedders] from comment #2) > What's in w3c/web-platform-tests/tools/third_party/ is slightly complicated > because WPT has generally avoided forking the libraries we vendor in, even > though we're largely on outdated versions (due to the necessity to support > Python 2 for WebKit). > I don't totally understand what this means, but my question is below. > All the expectation files in > html/webappapis/system-state-and-capabilities/the-navigator-object/ seem to > be orphaned, with no test associated with them, so those should just be > deletable? Guess our current import script doesn't manage to delete them? > Perhaps I'll post a patch for this shortly, or anyone else can if they get to it first. > Most of the rest seem to have been fixed upstream, at least. > Are the tests in w3c/web-platform-tests/tools/third_party/ also fixed upstream? Does our dependency on Python 2 make it difficult to update our copy? For all tests or just for those in third_party? > As for your question about lint.ignore: we can probably just apply > https://github.com/web-platform-tests/wpt/commit/ > 622c9625dddfdef0c6dfafa8fa00d5119db50201 locally? Perhaps I'll post a patch for this shortly, or anyone else can if they get to it first. % report-non-inclusive-language --verbose tools/manifest/tests/test_manifest.py: blacklist: 1 tools/third_party/py/CHANGELOG.rst: slave: 1 tools/third_party/py/doc/announce/release-1.2.0.txt: slave: 1 tools/third_party/py/doc/announce/release-1.3.0.txt: slave: 1 tools/third_party/py/doc/announce/release-1.3.2.txt: slave: 1 tools/third_party/h2/tox.ini: whitelist: 2 tools/third_party/attrs/pyproject.toml: whitelist: 1 tools/third_party/pytest/tox.ini: whitelist: 1 tools/third_party/pytest/doc/en/changelog.rst: blacklist: 1 tools/third_party/pytest/doc/en/changelog.rst: slave: 1 tools/third_party/pytest/doc/en/reference/reference.rst: whitelist: 1 tools/third_party/html5lib/CHANGES.rst: whitelist: 1 tools/third_party/html5lib/benchmarks/data/html.html: blacklist: 1 tools/third_party/html5lib/benchmarks/data/html.html: whitelist: 4 tools/third_party/typing_extensions/src/typing_extensions.py: whitelist: 3 _venv3/lib/python3.10/site-packages/pip/_internal/operations/check.py: whitelist: 4 _venv3/lib/python3.10/site-packages/pip/_vendor/typing_extensions.py: whitelist: 2 _venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: blacklist: 5 _venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: whitelist: 23 _venv3/lib/python3.10/site-packages/yaml/constructor.py: blacklist: 8 _venv3/lib/python3.10/site-packages/setuptools/_vendor/typing_extensions.py: whitelist: 3 _venv3/lib/python3.10/site-packages/pkg_resources/_vendor/typing_extensions.py: whitelist: 2 Total: 68 (blacklist: 16, whitelist: 47, slave: 5) Is what I get upstream. I filed https://github.com/web-platform-tests/wpt/issues/39998. I filed bug 213092 on what we can address in WebKit directly and created a PR for that. |