| Summary: | Stop speech recognition if page becomes invisible | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=220337 https://bugs.webkit.org/show_bug.cgi?id=220426 |
||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Sihui Liu
2020-12-21 15:09:18 PST
Created attachment 416637 [details]
Patch
Created attachment 416640 [details]
Patch
iOS failure might be due to https://bugs.webkit.org/show_bug.cgi?id=175204. I guess we should disable it for now but make sure this is working as expected through manual test. Comment on attachment 416640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416640&action=review > Source/WebKit/UIProcess/SpeechRecognitionServer.cpp:177 > + auto error = WebCore::SpeechRecognitionError { WebCore::SpeechRecognitionErrorType::Aborted, "Page became invisible"_s }; s/Page became invisible/Page is no longer visible/ Created attachment 417024 [details]
Patch for landing
(In reply to youenn fablet from comment #4) > iOS failure might be due to https://bugs.webkit.org/show_bug.cgi?id=175204. > I guess we should disable it for now but make sure this is working as > expected through manual test. Manually tested with Safari; recognition will abort when tab becomes invisible. Committed r271169: <https://trac.webkit.org/changeset/271169> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417024 [details]. This caused SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage to time out on macOS. EWS caught it, but after the patch had landed. https://bugs.webkit.org/show_bug.cgi?id=220337 Reverted r271169 for reason: Caused TestWebKitAPI.WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage to time out on macOS. Committed r271174: <https://trac.webkit.org/changeset/271174> Also of note: TestWebKitAPI.WebKit2.SpeechRecognitionPageBecomesInvisible, added with this patch, was asserting on Mojave bots
ASSERTION FAILED: !m_requests.contains(clientIdentifier)
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/SpeechRecognitionServer.cpp(58) : void WebKit::SpeechRecognitionServer::start(WebCore::SpeechRecognitionConnectionClientIdentifier, WTF::String &&, bool, bool, uint64_t, WebCore::ClientOrigin &&)
https://build.webkit.org/builders/Apple-Mojave-Debug-WK2-Tests/builds/13661/steps/run-api-tests/logs/stdio
Created attachment 417049 [details]
Patch
Created attachment 417089 [details]
Patch for landing
Downloading keyring-7.3.1... Installing keyring-7.3.1... Installed keyring-7.3.1! Downloading configparser-4.0.2... Installing configparser-4.0.2... Installed configparser-4.0.2! Downloading mechanize-0.4.5... Installing mechanize-0.4.5... Installed mechanize-0.4.5! ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Created attachment 417093 [details]
Patch for landing
Committed r271205: <https://trac.webkit.org/changeset/271205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417093 [details]. |