| Summary: | Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | REOPENED --- | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kangil.han, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 220591 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-12-21 09:23:32 PST
Created attachment 416606 [details]
Patch
Created attachment 416998 [details]
Patch
Comment on attachment 416998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416998&action=review > Source/WebCore/ChangeLog:20 > + When an interruption ends, all capture tracks are updated accorsing the page muted state, which is controlled by UIProcess. s/updated accorsing the page/updated according to the page/ > Source/WebKit/ChangeLog:172 > -2020-12-22 Youenn Fablet <youenn@apple.com> > +2020-12-21 Youenn Fablet <youenn@apple.com> Is this change intentional? > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:487 > + // We can only have one source at a time: we can mute all tracks but unmute only one of them. Nit: this and the comment below are duplicated in the audio and video loops, they could be moved up above instead. Created attachment 417445 [details]
Patch for landing
Committed r271401: <https://trac.webkit.org/changeset/271401> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417445 [details]. Re-opened since this is blocked by bug 220591 |