Bug 220040

Summary:

[LFC] Move content height logic to the formatting contexts.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2020-12-19 14:38:46 PST

Let's make the FCs compute their content heights.

Comment 1 zalan 2020-12-19 15:50:37 PST

Created attachment 416576 [details]
Patch

Comment 2 zalan 2020-12-19 15:52:01 PST

So this patch has a const_cast and I am curious of how to avoid that (other than making the contentHeight() functions static).

Comment 3 Simon Fraser (smfr) 2020-12-19 18:12:02 PST

Comment on attachment 416576 [details]
Patch

Very nice.

Comment 4 EWS 2020-12-20 07:11:34 PST

Committed r271012: <https://trac.webkit.org/changeset/271012>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416576 [details].

Comment 5 Radar WebKit Bug Importer 2020-12-20 07:12:22 PST

<rdar://problem/72518413>