Bug 220008

Summary:

Add tagging to JIT probe's return address.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	keith_miller: review+

Description Mark Lam 2020-12-17 23:30:26 PST

rdar://71279530

Comment 1 Mark Lam 2020-12-17 23:35:32 PST

Created attachment 416500 [details]
proposed patch.

Comment 2 Robin Morisset 2020-12-18 08:42:37 PST

Comment on attachment 416500 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=416500&action=review

LGTM, but I don't understand this code well enough to r+ it.

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp:524
> +    "sub       x27, x27, #" STRINGIZE_VALUE_OF(2 * GPREG_SIZE) "\n" // The retun point PC is at 2 instructions before the end of the probe.

retun -> return

Comment 3 Keith Miller 2020-12-18 10:58:33 PST

Comment on attachment 416500 [details]
proposed patch.

r=me

Comment 4 Mark Lam 2020-12-18 11:27:03 PST

Thanks for the reviews.  Landed in r270981: <http://trac.webkit.org/r270981>.