Bug 219979

Summary:	[GTK] gamepad/gamepad-polling-access.html is a flaky timeout
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, changseok, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Diego Pino 2020-12-16 23:24:10 PST

gamepad/gamepad-polling-access.html [ Timeout Pass ]

The test times out sometimes.

Firs timeout in last 4000 revision is at:

[r268451-r268452]             UNKNOWN
r268453                       TIMEOUT PASS (Expected: PASS)
[r268454-r268455]             UNKNOWN

It has been timing out more frequently lately.

The test takes an average of 3 seconds when passes successfully, so this is not a slow test.

Diff: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r270927%20(17517)/gamepad/gamepad-polling-access-diff.txt

Comment 1 Diego Pino 2021-04-28 20:25:40 PDT

The error can be reproduced running all the tests in the 'gamepad/' folder two times:

$ Tools/Scripts/run-webkit-tests --no-show-results --no-new-test-results --no-sample-on-timeout --results-directory layout-test-results --debug-rwt-logging --retry-failures --release --gtk --force --iterations=2 gamepad/

20:22:17.029 7 Starting 1 worker ...
20:22:17.130 7 worker/0 starting
20:22:17.962 7 worker/0 gamepad/gamepad-api.html passed
20:22:18.010 7 worker/0 gamepad/gamepad-event.html passed
20:22:18.770 7 worker/0 gamepad/gamepad-polling-access.html passed
20:22:18.953 7 worker/0 gamepad/gamepad-timestamp.html passed
20:22:19.063 7 worker/0 gamepad/gamepad-visibility-1.html passed
20:22:19.100 7 worker/0 gamepad/gamepad-api.html passed
20:22:19.137 7 worker/0 gamepad/gamepad-event.html passed
20:22:34.205 7 "ruby --version" took 0.02s
20:22:34.399 7 "ruby -I /app/webkit/Websites/bugs.webkit.org/PrettyPatch /app/webkit/Websites/bugs.webkit.org/PrettyPatch/prettify.rb /home/igalia/dpino/workspace/webkit/layout-test-results/gamepad/gamepad-polli
20:22:34.400 7 [8/10] gamepad/gamepad-polling-access.html failed unexpectedly (test timed out, text diff)
20:22:34.400 7 worker/0 killing driver
20:22:34.422 7 worker/0 gamepad/gamepad-polling-access.html failed:
20:22:34.422 7 worker/0  test timed out
20:22:34.422 7 worker/0  text diff
20:22:35.228 7 worker/0 gamepad/gamepad-timestamp.html passed

Unexpected flakiness: timeouts (1)
  gamepad/gamepad-polling-access.html [ Timeout Pass ]


Another interesting thing is that when running 'gamepad/gamepad-polling-access.html' two times, the test returns a text failure:

--- /home/igalia/dpino/workspace/webkit/layout-test-results/gamepad/gamepad-polling-access-expected.txt
+++ /home/igalia/dpino/workspace/webkit/layout-test-results/gamepad/gamepad-polling-access-actual.txt
@@ -1,133 +1,133 @@
 Initial gamepads length: 0
 Connecting 20 different gamepads
 Connecting gamepad:
-[object Gamepad]
+[object Gamepad],,,,,,,,,,[object Gamepad],,,,,,,,,
+Name: Awesome Joystick 5000
+Index: 10
+Mapping: standard
+Axes: 0.7,-0.9,1,-1
+Buttons: true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1 true-1
+Connecting gamepad:
+[object Gamepad],,,,,,,,,,[object Gamepad],,,,,,,,,
 Name: 0
 Index: 0
 Mapping:
 Axes:
 Buttons:
 Connecting gamepad:
-[object Gamepad],[object Gamepad]
+[object Gamepad],[object Gamepad],,,,,,,,,[object Gamepad],,,,,,,,,
...

Comment 2 Diego Pino 2023-01-10 07:45:30 PST

The test or tests filed under this bug are not failing anymore. Test expectations updated in https://commits.webkit.org/258724@main.

Comment 3 Radar WebKit Bug Importer 2023-01-10 07:49:15 PST

<rdar://problem/104077476>