Bug 219962

Summary: [LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2020-12-16 15:04:56 PST 
ssia
Comment 1 zalan 2020-12-16 15:35:49 PST 
Created attachment 416366 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-12-16 15:37:43 PST 
<rdar://problem/72402622>
Comment 3 zalan 2020-12-16 19:49:45 PST 
Created attachment 416382 [details]
Patch
Comment 4 zalan 2020-12-16 20:23:08 PST 
Created attachment 416385 [details]
Patch
Comment 5 Antti Koivisto 2020-12-16 23:27:08 PST 
Comment on attachment 416385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416385&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:345
> -void LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically(LineBox& lineBox)
> +void LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically(LineBox& lineBox)

The important fix!
Comment 6 zalan 2020-12-17 10:11:35 PST 
Created attachment 416435 [details]
Patch
Comment 7 zalan 2020-12-18 21:27:49 PST 
Created attachment 416567 [details]
Patch
Comment 8 EWS 2020-12-19 05:16:28 PST 
Committed r271002: <https://trac.webkit.org/changeset/271002>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416567 [details].