Bug 219961

<rdar://problem/72399014>

Created attachment 416374 [details]
Patch

Created attachment 416375 [details]
Patch

Created attachment 416376 [details]
Patch

Created attachment 416417 [details]
Patch

Comment on attachment 416417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416417&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:484
> +    if (!os_variant_allows_internal_security_policies("com.apple.WebKit"))

Since the value won't change at runtime, can you break this out into a helper function that caches the result of os_variant_allows_internal_security_policies() in a static bool? This was my mistake from earlier, but maybe you can fix it while you're here :)

Comment on attachment 416417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416417&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:447
> +bool SourceBufferParserWebM::m_formatReaderEnabled = false;

Since globals are initialized to 0 by default, no need for the ` = false` here.

Created attachment 416419 [details]
Patch

Created attachment 416420 [details]
Patch for landing

Created attachment 416425 [details]
Patch for landing

Created attachment 416428 [details]
Patch for landing

Created attachment 416443 [details]
Final patch for landing

Committed r270939: <https://trac.webkit.org/changeset/270939>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416443 [details].

Comment on attachment 416443 [details]
Final patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=416443&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:483
> +#endif
> +
> +#if USE(APPLE_INTERNAL_SDK)

This should be elif so we don’t compile multiple return statements.

Reopening to attach new patch.

Created attachment 416465 [details]
Address post-review comments.

Committed r270952: <https://trac.webkit.org/changeset/270952>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416465 [details].

Comment on attachment 416419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416419&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:105
> +    static auto cache = makeNeverDestroyed([this] {
> +        UNUSED_PARAM(this);

Why do we capture "this"?

Comment on attachment 416419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416419&action=review

>> Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:105
>> +        UNUSED_PARAM(this);
> 
> Why do we capture "this"?

That was left over from a earlier version of the patch, but it was removed before landing.

Reverted r270939 and r270952 for reason:

Caused layout test timeouts on internal bots

Committed r271038: <https://trac.webkit.org/changeset/271038>

Reverted r270939 and r270952 for reason:

Caused layout test timeouts on internal bots

Committed r271038: <https://trac.webkit.org/changeset/271038>

Details in rdar://72484508

Created attachment 417051 [details]
Patch

Created attachment 417058 [details]
Patch

Created attachment 417060 [details]
Patch

Created attachment 417061 [details]
Patch

Created attachment 417062 [details]
Patch

Committed r271194: <https://trac.webkit.org/changeset/271194>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417062 [details].