Bug 219934

Summary: [Flatpak SDK] coredumpctl invocation when using a local SDK repo fallbacks to the remote repo
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: Tools / TestsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, ews-watchlist, glenn, jbedard, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219933
Attachments:
Description Flags
Patch pnormand: review+

Description Lauro Moura 2020-12-15 22:16:32 PST 
While investigating bug219933, building the updated SDK followed by running `update-webkit-flatpak`, running a test that crashes shows the following message:

```
Flatpak package org.webkit.Sdk.Debug/x86_64/0.3 not installed. Please update your SDK: Tools/Scripts/update-webkit-flatpak
```

Digging a bit deeper, indeed org.webkit.Sdk.Debug was not being shown in the output of `flatpak list` when generating the list of FlatpakPackages in flatpakutils.py, despite executing the same command in the shell[1] shows the Debug component (org.webkit.Sdk.Locale is present though).

The issue is that linux_get_crash_log.py's _get_trace_from_flatpak invokes webkit-flatpak on the host without keeping the WEBKIT_FLATPAK_USER_DIR variable, making it fall back to the regular remote repo scheme. In my case, installing the remote packages. Due to the silent and lengthy process, after a ctrl+c this remote clone ended incomplete, thus the missing org.webkit.Sdk.Debug message.

WIP patch already working. Will submit after cleanup.

[1] `flatpak list --user --columns=application,arch,branch,origin -a`
Comment 1 Lauro Moura 2021-01-05 07:51:13 PST 
Created attachment 417004 [details]
Patch
Comment 2 Philippe Normand 2021-01-05 08:29:32 PST 
Comment on attachment 417004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417004&action=review

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:117
> +        user_dir = os.environ.get('WEBKIT_FLATPAK_USER_DIR')
> +        if user_dir:
> +            cmd.append("--env=WEBKIT_FLATPAK_USER_DIR=%s" % user_dir)

Might be simpler to pass-through the env to popen?
Comment 3 Lauro Moura 2021-01-05 10:22:22 PST 
(In reply to Philippe Normand from comment #2)
> Comment on attachment 417004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417004&action=review
> 
> > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:117
> > +        user_dir = os.environ.get('WEBKIT_FLATPAK_USER_DIR')
> > +        if user_dir:
> > +            cmd.append("--env=WEBKIT_FLATPAK_USER_DIR=%s" % user_dir)
> 
> Might be simpler to pass-through the env to popen?

It's already passed through env as it's popen's default behavior to inherit the environment.

The issue is that flatpak-spawn needs to be instructed which "non default" variables needs to be exported when creating the new shell for the new host command.
Comment 4 Lauro Moura 2021-01-06 05:45:34 PST 
Committed r271199: <https://trac.webkit.org/changeset/271199>
Comment 5 Radar WebKit Bug Importer 2021-01-06 05:46:21 PST 
<rdar://problem/72849449>