| Summary: | [CMake][WPE] Add LibWPE before WPEBackend-FDO for qtwpe_INCLUDE_DIRECTORIES | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pablo Saavedra <psaavedra> | ||||
| Component: | CMake | Assignee: | Pablo Saavedra <psaavedra> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, aperez, calvaris, don.olmstead, ews-watchlist, gyuyoung.kim, mcatanzaro, pnormand, ryuan.choi, sergio | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 416290 [details]
patch
Committed r270880: <https://trac.webkit.org/changeset/270880> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416290 [details]. |
... included as System libraries. In other case a build error like this can happen: #error "Only <wpe/fdo.h> can be included directly." ; because the wpe-1.0/wpe/wpe.h looks for the version.h header but it finds the wpe-fdo-1.0/wpe/version.h instead of from wpe-1.0 because the WPEBackend-FDO lib is defined as system lib and the libWPE library not. The way to avoid this it could ensuring the right order of the -isystem flags by appending before the LibWPE as a system lib: `list(APPEND WebCore_LIBRARIES ${WPE_INCLUDE_DIRS})` before adding the WPEbackend-fdo system libraries. Similar fix: https://bugs.webkit.org/show_bug.cgi?id=219835