Bug 219881

Summary: Get more informatiton from assertion when uidna_openUTS46 fails
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-12-14 17:01:59 PST 
Get more informatiton from assertion when uidna_openUTS46 fails
Comment 1 Alex Christensen 2020-12-14 17:03:37 PST 
Created attachment 416211 [details]
Patch
Comment 2 Alex Christensen 2020-12-14 17:03:40 PST 
<rdar://problem/66988046>
Comment 3 Alex Christensen 2020-12-14 17:13:47 PST 
Created attachment 416214 [details]
Patch
Comment 4 Alexey Proskuryakov 2020-12-14 17:25:08 PST 
Comment on attachment 416214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416214&action=review

> Source/WTF/wtf/URLParser.cpp:2864
> +            RELEASE_ASSERT(error == U_MEMORY_ALLOCATION_ERROR);

May be worth logging the error to system log. It's hard to imagine any other reason for the failure, but it's hard to run out of address space, too.
Comment 5 Alex Christensen 2020-12-14 18:23:33 PST 
Created attachment 416219 [details]
Patch
Comment 6 Alex Christensen 2020-12-14 18:26:49 PST 
Created attachment 416220 [details]
Patch
Comment 7 EWS 2020-12-14 18:59:20 PST 
Committed r270818: <https://trac.webkit.org/changeset/270818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416220 [details].