| Summary: | [macOS] Adjust date input placeholder color based on specified text color | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aditya Keerthi
2020-12-14 15:00:12 PST
Created attachment 416197 [details]
Patch
Comment on attachment 416197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416197&action=review Really great changes! > LayoutTests/ChangeLog:12 > + * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added. It’s a little disappointing when we can only create a mismatch test, since there are so many ways for such tests to pass (false negative). Can we make a reference test, carefully choosing colors so the placeholder text can be reproduced with some other mechanism. Or is that impractical? Created attachment 416287 [details]
Patch for landing
(In reply to Darin Adler from comment #3) > Comment on attachment 416197 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416197&action=review > > Really great changes! Thanks for the review! > > LayoutTests/ChangeLog:12 > > + * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added. > > It’s a little disappointing when we can only create a mismatch test, since > there are so many ways for such tests to pass (false negative). > > Can we make a reference test, carefully choosing colors so the placeholder > text can be reproduced with some other mechanism. Or is that impractical? I removed the mismatch test and replaced it with a reference test that reproduces the placeholder text by setting the value of the input to the current date, and styling the day/month/year fields. Committed r270875: <https://trac.webkit.org/changeset/270875> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416287 [details]. |