| Summary: | Add webkit- prefix to SpeechRecognition | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sihui Liu
2020-12-14 12:08:02 PST
Created attachment 416182 [details]
Patch
Created attachment 416205 [details]
Patch
Created attachment 416207 [details]
WIP
Created attachment 416224 [details]
Patch
Comment on attachment 416224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416224&action=review > Source/WebCore/Modules/speech/SpeechRecognition.idl:29 > + InterfaceName=webkitSpeechRecognition, I think we might want to have both webkitSpeechRecognition and SpeechRecognition be defined. I would add a separate setting to enable this prefixed version as well, like done for web audio. (In reply to youenn fablet from comment #5) > Comment on attachment 416224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416224&action=review > > > Source/WebCore/Modules/speech/SpeechRecognition.idl:29 > > + InterfaceName=webkitSpeechRecognition, > > I think we might want to have both webkitSpeechRecognition and > SpeechRecognition be defined. > I would add a separate setting to enable this prefixed version as well, like > done for web audio. Per discussion on Slack, I guess we are Okay with only prefix version first. Comment on attachment 416224 [details]
Patch
r=me
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 416292 [details]
Patch for landing
Committed r270868: <https://trac.webkit.org/changeset/270868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416292 [details]. |