Bug 219852

Summary: [macOS] Add sandbox parameter for message filter entitlement status
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219935    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
bfulgham: review+
Patch
none
Patch none

Per Arne Vollan
Reported 2020-12-14 06:40:01 PST
Add sandbox parameter to determine whether the WebContent process has message filter entitlement. This parameter will be used in the sandbox to enable message filtering.
Attachments
Patch (29.40 KB, patch)
2020-12-14 06:55 PST, Per Arne Vollan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (29.44 KB, patch)
2020-12-14 07:57 PST, Per Arne Vollan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch (14.37 KB, patch)
2020-12-15 04:25 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (14.52 KB, patch)
2020-12-16 02:31 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-12-14 06:49:49 PST
<rdar://problem/72145560>
Per Arne Vollan
Comment 2 2020-12-14 06:55:19 PST
Created attachment 416153 [details] Patch
Per Arne Vollan
Comment 3 2020-12-14 07:57:06 PST
Created attachment 416159 [details] Patch
Brent Fulgham
Comment 4 2020-12-14 09:50:10 PST
Comment on attachment 416159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416159&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:119 > + (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") Is it not possible to have the conditional just apply to the message filter bit of the code? That might make this easier to understand.
Per Arne Vollan
Comment 5 2020-12-14 10:35:21 PST
(In reply to Brent Fulgham from comment #4) > Comment on attachment 416159 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416159&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:119 > > + (if (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") > > Is it not possible to have the conditional just apply to the message filter > bit of the code? That might make this easier to understand. That would be better, but it does not seem to be possible, since the if clause cannot appear inside another clause, it appears. Thanks for reviewing!
Brent Fulgham
Comment 6 2020-12-14 16:30:17 PST
Comment on attachment 416159 [details] Patch Lots of indenting! r=me
Per Arne Vollan
Comment 7 2020-12-15 04:25:19 PST
Created attachment 416235 [details] Patch
Per Arne Vollan
Comment 8 2020-12-15 04:25:58 PST
(In reply to Brent Fulgham from comment #6) > Comment on attachment 416159 [details] > Patch > > Lots of indenting! r=me Fixed in latest patch. Thanks for reviewing!
EWS
Comment 9 2020-12-15 04:54:00 PST
Committed r270829: <https://trac.webkit.org/changeset/270829> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416235 [details].
WebKit Commit Bot
Comment 10 2020-12-15 22:56:22 PST
Re-opened since this is blocked by bug 219935
Per Arne Vollan
Comment 11 2020-12-16 02:31:38 PST
Created attachment 416321 [details] Patch
EWS
Comment 12 2020-12-16 05:36:05 PST
Committed r270887: <https://trac.webkit.org/changeset/270887> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416321 [details].
Note You need to log in before you can comment on or make changes to this bug.