| Summary: | Remove WKDownloadDelegate.didWriteData | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | james.savage, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-12-11 21:01:11 PST
Created attachment 416086 [details]
Patch
Comment on attachment 416086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416086&action=review > Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:221 > + downloadProgress = [NSProgress progressWithTotalUnitCount:-1]; Presumably -1 is a sentinel for undetermined/indeterminate progress? Why was this 100 originally? It is, and a download that has an unknown content length uses -1. I initially used 100 based on NSURLSession's behavior, but I decided it would be better to consistently use -1 for non-determined length. james.savage@apple.com does not have reviewer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 416086 [details] from commit queue. Comment on attachment 416086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416086&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:221 >> + downloadProgress = [NSProgress progressWithTotalUnitCount:-1]; > > Presumably -1 is a sentinel for undetermined/indeterminate progress? Why was this 100 originally? Maybe throwing the -1 into a constant will help clear this up. Created attachment 416169 [details]
Patch
Committed r270790: <https://trac.webkit.org/changeset/270790> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416169 [details]. |