Bug 219819

Summary:

[WebM] Mark Opus and Vorbis as supported track types.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric.carlson, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jer Noble 2020-12-11 18:39:30 PST

[WebM] Mark Opus and Vorbis as supported track types.

Comment 1 Jer Noble 2020-12-11 18:59:59 PST

Created attachment 416084 [details]
Patch

Comment 2 Jer Noble 2020-12-11 19:02:09 PST

Committed r270728: <http://trac.webkit.org/r270728>

Comment 3 Radar WebKit Bug Importer 2020-12-11 19:02:31 PST

<rdar://problem/72247829>

Comment 4 Darin Adler 2020-12-17 09:49:19 PST

Comment on attachment 416084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416084&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:1210
> +#if ENABLE(VORBIS)
> +        "A_VORBIS",
> +#endif
> +#if ENABLE(OPUS)
> +        "A_OPUS",
> +#endif

Not important, but can slightly optimize by adding _s to these.