| Summary: | Fix for accessibility layout tests related to VisiblePositions in isolated tree mode. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-12-11 15:13:03 PST
Created attachment 416052 [details]
Patch
Comment on attachment 416052 [details]
Patch
seems ok if tests pass.
slightly worried that updating children in render object hit test will cause perf issues
Created attachment 416156 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 416052 [details] > Patch > > seems ok if tests pass. > slightly worried that updating children in render object hit test will cause > perf issues Agree, particularly I'm not sure about the impact on iOS, so I reverted that part of the change. Committed r270787: <https://trac.webkit.org/changeset/270787> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416156 [details]. |