Bug 219803

Summary: [webkitscmpy] Load mock repository data from json file
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219602
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-12-11 13:19:58 PST 
As per a discussion Stephanie and I had in https://bugs.webkit.org/show_bug.cgi?id=219602, we should pull the mock data from inside the mock objects and put it in json files.
Comment 1 Radar WebKit Bug Importer 2020-12-11 13:20:40 PST 
<rdar://problem/72236132>
Comment 2 Jonathan Bedard 2020-12-11 13:43:14 PST 
Created attachment 416039 [details]
Patch
Comment 3 Jonathan Bedard 2020-12-11 13:53:56 PST 
Created attachment 416043 [details]
Patch
Comment 4 Stephanie Lewis 2020-12-11 15:22:36 PST 
Comment on attachment 416043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416043&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:35
> +        self, path='/.invalid-git', data=None,

nit: data to me implies that the file has already been read
Comment 5 Jonathan Bedard 2020-12-14 07:39:13 PST 
Created attachment 416155 [details]
Patch for landing
Comment 6 EWS 2020-12-14 08:34:57 PST 
Committed r270769: <https://trac.webkit.org/changeset/270769>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416155 [details].