| Summary: | Rework of AXObjectCache::isIsolatedTreeEnabled. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andres Gonzalez
2020-12-09 17:59:53 PST
Created attachment 415818 [details]
Patch
Comment on attachment 415818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415818&action=review > Source/WebCore/ChangeLog:19 > + - Renamed canUseSecondaryAXThread to UsedOnAXThread, which is aa more aa -> a > Source/WebCore/accessibility/AXObjectCache.cpp:748 > + if (!isMainThread()) I feel like to be completely safe this should be if (!isMainThread() && _AXUIElementRequestServicedBySecondaryAXThread() in the deviant case where the AX request is being handled on some other background thread unexpectedly (or maybe do an ASSERT(_AXUIElementRequestServicedBySecondaryAXThread()) in the !isMainThread case Created attachment 415864 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 415818 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415818&action=review > > > Source/WebCore/ChangeLog:19 > > + - Renamed canUseSecondaryAXThread to UsedOnAXThread, which is aa more > > aa -> a Fixed. > > > Source/WebCore/accessibility/AXObjectCache.cpp:748 > > + if (!isMainThread()) > > I feel like to be completely safe this should be > > if (!isMainThread() && _AXUIElementRequestServicedBySecondaryAXThread() > > in the deviant case where the AX request is being handled on some other > background thread unexpectedly > > (or maybe do an ASSERT(_AXUIElementRequestServicedBySecondaryAXThread()) in > the !isMainThread case Added the ASSERT. Created attachment 415868 [details]
Patch
Committed r270647: <https://trac.webkit.org/changeset/270647> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415868 [details]. |