Bug 219688

Summary: Pass an isolated copy of Settings to workers and worklets.
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kangil.han, keith_miller, mark.lam, msaboff, philipj, saam, sam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 219252, 267196    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2020-12-09 08:32:51 PST
Pass an isolated copy of Settings to workers and worklets.
Comment 1 youenn fablet 2020-12-09 08:49:46 PST
Created attachment 415763 [details]
Patch
Comment 2 Sam Weinig 2020-12-13 08:36:28 PST
Comment on attachment 415763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415763&action=review

This is fantastic work! Thanks Youenn!

> Source/WebCore/ChangeLog:10
> +
> +        Generate a Settings::Values struct containing all setting values.
> +        Workers and worklets get that structure from their document and do a thread safe copy to use it in the background thread.
> +        Covered by existing tests in workers.

Got a case of the double ChangeLogs.
Comment 3 youenn fablet 2020-12-14 00:21:04 PST
Created attachment 416139 [details]
Patch for landing
Comment 4 EWS 2020-12-14 01:44:22 PST
Committed r270762: <https://trac.webkit.org/changeset/270762>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416139 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-14 01:45:19 PST
<rdar://problem/72288687>