Bug 219676

Summary:

Build error after r270457

Product:

WebKit

Reporter:

Pablo Saavedra <psaavedra>

Component:

Web Audio

Assignee:

Pablo Saavedra <psaavedra>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, cdumez, darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	cdumez: review-

Description Pablo Saavedra 2020-12-09 03:45:03 PST

Related with https://bugs.webkit.org/show_bug.cgi?id=219546


Error:


../../Source/WebCore/platform/audio/SincResampler.cpp: In member function �~@~Xfloat WebCore::SincResampler::convolve(const float*, const float*, const float*, float)�~@~Y:
../../Source/WebCore/platform/audio/SincResampler.cpp:339:35: error: �~@~XkKernelSize�~@~Y was not declared in this scope; did you mean �~@~XkernelSize�~@~Y?
  339 |     const float* upper = inputP + kKernelSize;
      |                                   ^~~~~~~~~~~
      |                                   kernelSize



It seems kKernelSize defined for Source/WebCore/platform/audio/SincResampler.h|cpp

... but it is defined in Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/sinc_resampler.h

class SincResampler {
 public:
  // The kernel size can be adjusted for quality (higher is better) at the
  // expense of performance.  Must be a multiple of 32.
  // TODO(dalecurtis): Test performance to see if we can jack this up to 64+.
  static const size_t kKernelSize = 32;

Comment 1 Pablo Saavedra 2020-12-09 03:51:01 PST

Created attachment 415737 [details]
patch

Comment 2 Chris Dumez 2020-12-09 08:24:36 PST

Comment on attachment 415737 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415737&action=review

> Source/WebCore/platform/audio/SincResampler.h:51
> +    static const size_t kKernelSize = 32;

See in SincResampler.cpp:
constexpr unsigned kernelSize { 32 };

We should be using kernelSize, not kKernelSize.

Comment 3 Chris Dumez 2020-12-09 08:31:16 PST

Committed r270581: <https://trac.webkit.org/changeset/270581>

Comment 4 Radar WebKit Bug Importer 2020-12-09 08:32:19 PST

<rdar://problem/72137809>

Comment 5 Pablo Saavedra 2020-12-09 09:55:39 PST

(In reply to Chris Dumez from comment #3)
> Committed r270581: <https://trac.webkit.org/changeset/270581>

OK. Thanks.